-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Penner's functions approximation results in sloppy animations #591
Comments
Hey thanks for pointing this out. |
Fixed in v3.1.0! |
@juliangarnier Can you elaborate? |
@web2033 yes, no API change, just more accurate functions. |
@juliangarnier I realised Quad, Cubic, Quart, Quint, and Expo penner functions are still returning some approximated and inaccurate results. It can be showcased in the original codepen : https://codepen.io/mrgnouqsdqsd/pen/ZgEVZR |
@juliangarnier Hoy, I guess this issue should be reopened as it has not been completely fixed. It forces the use of external libs with custom ease function on each anime() call. |
Quad, Cubic, Quart, Quint issues have been fixed in |
It seems the Robert Penner's equations are approximated, resulting in very sloppy animations compared to the original simplified functions.
Here's a simple demo exposing easeInOutExpo wrong behaviour:
https://codepen.io/mrgnouqsdqsd/pen/ZgEVZR
I appreciate the effort to keep the lib very light, but we really can't mess with these equations in an animation library.
Simplified equations: https://github.com/greensock/GreenSock-JS/blob/master/src/uncompressed/easing/EasePack.js
The text was updated successfully, but these errors were encountered: