Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: interpolated variables in strings need parentheses #2042

Closed
odow opened this issue Aug 23, 2019 · 2 comments · Fixed by #2063
Closed

Style: interpolated variables in strings need parentheses #2042

odow opened this issue Aug 23, 2019 · 2 comments · Fixed by #2063

Comments

@odow
Copy link
Member

odow commented Aug 23, 2019

I propose that all interpolated variables in strings need parentheses.

Good:

x = 1
"Interpolated x=$(x) with parentheses.

Bad:

x = 1
"Interpolated x=$x without parentheses.

This stems from a potential breaking change between Julia 1.2 and Julia 1.3. See JuliaLang/julia#33044.

@mlubin
Copy link
Member

mlubin commented Aug 23, 2019

Let's wait for a resolution on the Julia issue. Also, we don't need style points to cover pieces of code that don't compile, we should just run 1.3 on CI.

@odow
Copy link
Member Author

odow commented Aug 23, 2019

Okay. This is fixed on latest Julia master, so we can probably close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants