Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP All Import download fails. #64

Open
jmotes opened this issue May 10, 2023 · 14 comments
Open

WP All Import download fails. #64

jmotes opened this issue May 10, 2023 · 14 comments

Comments

@jmotes
Copy link

jmotes commented May 10, 2023

See error in screenshot. This just started happening today - not sure why.

I looked at the source code and tried to reconstruct the download URL like so:

https://www.wpallimport.com/?edd_action=version&license=[MY_LICENSE_KEY]&item_name=WP%20All%20Import&url=https%3A%2F%2Ftest.com%2F&version=4.7.9

That didn't work so I'm guessing that URL has changed unless I'm doing something wrong.

EDIT: I had an issue with the URL. This one works:
https://www.wpallimport.com/?edd_action=get_version&license=[MY_LICENSE_KEY]&item_name=WP%20All%20Import&url=https%3A%2F%2Ftest.com%2F&version=4.7.9

I'm not sure what could be the issue now. If it matters, I'm using Composer 2.4.2.

image

@jmotes jmotes changed the title WP All Import download fails. Url changed? WP All Import download fails. May 10, 2023
@mattneal-stafflink
Copy link

I've got the exact same issue atm.

@mcaskill
Copy link
Contributor

mcaskill commented May 11, 2023

Hrm. It must be an issue with WPAI's server if extractDownloadUrl() is receiving null.

null is returned if the JSON cannot be decoded or if the encoded data is deeper than the nesting limit.

$response = json_decode( $http->get( 'https://www.wpallimport.com', array(
	'edd_action' => 'get_version',
	'license'    => $license,
	'item_name'  => $name,
	'url'        => $url,
	'version'    => $this->version,
) ), true );

return $this->extractDownloadUrl( $response );

This portion could benefit from some extra logic to intercept the failed decoding and throw a relevant message.

Ha. I completely forgot I had thought of this and have addressed in #58 that I proposed in March but don't have time to test and finish.

@jmotes
Copy link
Author

jmotes commented May 11, 2023

Thought I'd link to this old ticket I just remembered from last year. Wonder if it's the same issue again: #41

@jmotes
Copy link
Author

jmotes commented May 11, 2023

It's been working again for me today. It working for everyone else too now?

@junaidbhura
Copy link
Owner

WP All Import are notoriously unstable. Is it working for everyone again today?

@mcaskill
Copy link
Contributor

Indeed. WPAI appears to be the most common issue. We should add a specific notice about it in both the README and in the error messages reported by Composer.

@justlevine
Copy link

I also started running into this 2 weeks ago. Interestingly, it was only happening on my local machine and not my CI.

Copying over the changes to the Http class made in #58 showed me the issue wasnt actually with WPAI (for a change), but cURL error (60): SSL certificate problem: unable to get local issuer certificate, and updating the wp-includes/certificates/ca-bundle.crt fixed it for me.

@mcaskill
Copy link
Contributor

cURL error (60): SSL certificate problem: unable to get local issuer certificate

That's a good find and something the Composer plugin could try to check for in the HTTP response to report to the user.

@jmotes
Copy link
Author

jmotes commented Jul 20, 2023

Having problems again today 😓

@justlevine
Copy link

@jmotes I think we can probably assume at this point that all wpai errors are caused by their servers and not this repo.

@jmotes
Copy link
Author

jmotes commented Jul 20, 2023

@justlevine Yeah - it definitely seems to be Cloudflare blocking us again. Since I'm using Azure Devops for CI/CD I decided to just upload all of the WPAI suite plugins to the project's secure files library and unarchive them at build time to create my deployment artifact. It took a couple hours out of my morning to get it all working but happy to have something a bit more failproof without committing them directly to the repo.

It stinks that I have to re-upload the plugins every time I want to update to the latest version (which this project handles nicely) but at least I can continue using it for Gravity Forms and ACF.

@junaidbhura
Copy link
Owner

Hey everyone, please share your thoughts here: #69

@Twansparant
Copy link

Jup, same error here since yesterday...

@nikolowry
Copy link

It be nice to drop https://github.com/junaidbhura/composer-wp-pro-plugins/blob/master/src/Plugins/AbstractEddPlugin.php#L39-L46 for the WPAI plugins -- or at least offer some type of ENV/flag to skip that check entirely.

My CI/CD builds are failing because the version got pinned in composer.lock, even though I've specified * for the version in my composer.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants