Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab-myst extension causes issues problems with viewing the notebook in the browser #166

Closed
MatusGasparik opened this issue Jun 30, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@MatusGasparik
Copy link

Description

I worked on a notebook yersterday and today I noticed that large chunks of it (basically everything except for the top cell with some imports) was misteriously missing. But the notebook file is big, cat-ing it relealed that the content is there, it just want show in the browser for some reason.

I checked the browser console and saw something related to this extension:

image

So I tried deactivating the extension in the left-panel and refreshing and voilà - the notebook contenst magically appeared:

Bildschirmaufnahme 2023-06-30 um 09 52 53

Additional notes

Versions

  • jupyterlab-myst: 1.2.0
  • jupyterlab: 4.0.0
  • chrome: 114.0.5735.198
  • OS: macOS 12.6.2 (Apple M1 Max)
@MatusGasparik MatusGasparik added the bug Something isn't working label Jun 30, 2023
@welcome
Copy link

welcome bot commented Jun 30, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@agoose77
Copy link
Collaborator

agoose77 commented Jun 30, 2023

Thank you for the bug report! Would you be able to share the notebook that causes this?

@rowanc1
Copy link
Collaborator

rowanc1 commented Jul 4, 2023

Thanks @MatusGasparik for the bug report. @agoose77 it could potentially be this line:
https://github.com/executablebooks/jupyterlab-myst/blob/dedbb1d785a02612da05fa798c7091c25b607a59/src/metadata.ts#L13

Do you know by chance when getMetadata was introduced, perhaps later than JupyterLab 4.0.0?

@rowanc1
Copy link
Collaborator

rowanc1 commented Jul 4, 2023

Actually, @MatusGasparik please upgrade to v2.0.0 of the jupyterlab-myst library, the previous one was not compatible with JupyterLab 4.0!

@rowanc1 rowanc1 closed this as completed Jul 4, 2023
@agoose77
Copy link
Collaborator

agoose77 commented Jul 4, 2023

@rowanc1 good eyes. I misread the version as 2.0, this makes much more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants