Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on @jupyterlab/codemirror #666

Open
stevejpurves opened this issue Jul 14, 2023 · 0 comments
Open

Remove dependency on @jupyterlab/codemirror #666

stevejpurves opened this issue Jul 14, 2023 · 0 comments

Comments

@stevejpurves
Copy link
Collaborator

thebe uses Mode.ensure() from the @juptyerlab/codemirror package in order to load mode files on demand. That function has been removed in jlab 4.x resulting in the pin here.

However, we can avoid loading that package altogether by implementing the ensure behaviour here. Also this can be much simpler than the jlab implementation as we know that the incoming mode to be a string indicating language name (we might also consider supporting the extension, as that is a standard CodeMirror lookup) rather than the variety of arguments that jlab has to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant