Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the deprecated /metrics endpoint #75

Closed
jtpio opened this issue Dec 3, 2020 · 1 comment · Fixed by #77
Closed

Drop the deprecated /metrics endpoint #75

jtpio opened this issue Dec 3, 2020 · 1 comment · Fixed by #77
Milestone
0.5.0

Comments

@jtpio
Copy link
Member

jtpio commented Dec 3, 2020

Originally posted by @manics in #73 (comment)

If you're renaming the package this might be a good opportunity to make any breaking changes? e.g. following up from #68 /metrics could be completely removed instead of just deprecated?

We should consider doing this for the next major release, so adding to the 0.5.0 milestone.
@jtpio jtpio added this to the 0.5.0 milestone Dec 3, 2020
@yuvipanda
Copy link
Collaborator

yuvipanda commented Dec 3, 2020 •
edited
Loading

YESSS. LET US KILL IT.

This was referenced Dec 9, 2020
Closed
Open
Merged
@jtpio jtpio closed this as completed in #77 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Drop the deprecated /metrics endpoint 🔥 🔥 🔥 jtpio/jupyter-resource-usage
2 participants
@yuvipanda @jtpio