-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a jupyter_server
extension for the classic notebook.
#18
Comments
Following some discussions with @minrk on this. There are two main ways to go with this
The second approach would be more disruptive for the classic notebook repository which is presumably under maintenance mode, but would result in less duplication. Also, it would mean that the classic notebook would need to be updated upon backward incompatible changes in cc @takluyver @gnestor. |
👍 for the second approach, I think it is easier to explain to users as well. |
I think second approach sounds better too |
Here's my experiment—making the classic notebook a jupyter_server extension (using the API from #48). It's so much cleaner! https://github.com/Zsailer/notebook_server_extension @SylvainCorlay — Should I open a the dracarys PR in notebook? 😉 |
See this PR in the classic notebook. |
Closing for now, since NBClassic exists. |
This could be in a
classic_notebook
repository on the jupyter organization, or as a PR on the actual classic notebook (with a greater risk of not being merged).The
classic_notebook
extension could be a way to enable the classic notebook button with JupyterLab when it is installed on the top of the jupyter_server.The text was updated successfully, but these errors were encountered: