Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a jupyter_server extension for the classic notebook. #18

Closed
SylvainCorlay opened this issue Jul 28, 2018 · 6 comments
Closed

Create a jupyter_server extension for the classic notebook. #18

SylvainCorlay opened this issue Jul 28, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@SylvainCorlay
Copy link
Contributor

SylvainCorlay commented Jul 28, 2018

This could be in a classic_notebook repository on the jupyter organization, or as a PR on the actual classic notebook (with a greater risk of not being merged).

The classic_notebook extension could be a way to enable the classic notebook button with JupyterLab when it is installed on the top of the jupyter_server.

@SylvainCorlay
Copy link
Contributor Author

Following some discussions with @minrk on this. There are two main ways to go with this

  1. Create a new classic_notebook project which either depends on notebook and allows the jupyter server to server the classic notebook JavaScript.
  2. Open a PR to the notebook repository to make it use the Jupyter server.

The second approach would be more disruptive for the classic notebook repository which is presumably under maintenance mode, but would result in less duplication. Also, it would mean that the classic notebook would need to be updated upon backward incompatible changes in jupyter_server... An advantage though would be that PRs improving the current notebook server would apply to jupyter_server and won't fall between the cracks.

cc @takluyver @gnestor.

@blink1073
Copy link
Contributor

👍 for the second approach, I think it is easier to explain to users as well.

@gnestor
Copy link
Contributor

gnestor commented Aug 7, 2018

I think second approach sounds better too

@Zsailer
Copy link
Member

Zsailer commented May 19, 2019

Here's my experiment—making the classic notebook a jupyter_server extension (using the API from #48). It's so much cleaner!

https://github.com/Zsailer/notebook_server_extension

@SylvainCorlay — Should I open a the dracarys PR in notebook? 😉

@Zsailer
Copy link
Member

Zsailer commented Jun 3, 2019

See this PR in the classic notebook.

@Zsailer Zsailer added this to the 0.2.0 Release milestone Dec 2, 2019
@Zsailer Zsailer self-assigned this Dec 2, 2019
@echarles echarles modified the milestones: 0.2.0 Release, 0.3.0 Release Jan 4, 2020
@Zsailer
Copy link
Member

Zsailer commented Apr 15, 2020

Closing for now, since NBClassic exists.

@Zsailer Zsailer closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants