Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-blocking nbconvert handler #197

Open
davidbrochart opened this issue Jul 31, 2022 · 0 comments
Open

Non-blocking nbconvert handler #197

davidbrochart opened this issue Jul 31, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@davidbrochart
Copy link
Collaborator

Problem

Currently, the nbconvert handler makes a blocking call, which can hurt the server performances.

Proposed Solution

We should run nbconvert in a separate thread, possibly using anyio.to_thread's run_sync, or wait for nbconvert to get an async API.
@davidbrochart davidbrochart added the enhancement New feature or request label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidbrochart