Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Revive Pytest Jupyter #41

Closed
blink1073 opened this issue Nov 14, 2022 · 1 comment
Closed

Proposal: Revive Pytest Jupyter #41

blink1073 opened this issue Nov 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@blink1073
Copy link
Contributor

blink1073 commented Nov 14, 2022

I would like to propose bringing the pytest-jupyter project out of archive. We had earlier decided to archive it because the package's use of pytest entry points was causing subtle errors with other pytest plugins (such as pytest-tornasync).

We have had great success in using the fixtures from jupyter_server, but it makes more sense for some of those to be more widely available. We could add them to an existing package like jupyter_core or jupyter_client, but then our tests would depend on a newer version of those libraries.

I think we should bring back pytest-jupyter and remove the pytest entrypoint, and instead make the fixtures usable with pytest_plugins = ["pytest-jupyter"].

We could add the following things to what is already in the repo (which include environment setup and other core fixtures):

  • A fork of tornasync with our overrides from jupyter_server
  • An echo kernel class and helper fixtures that can be used in testing, which we're already doing in JupyterLab for most tests, which would drastically improve test speed for jupyter_client and jupyter_server, among others.
@blink1073 blink1073 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 14, 2022
@blink1073
Copy link
Contributor Author

We decided in the meeting that we will proceed with this idea, I'm unarchiving the repo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant