From 188abff9a1fe5509c48a98995387b2cd55299744 Mon Sep 17 00:00:00 2001 From: martinRenou Date: Wed, 21 Aug 2024 13:28:49 +0100 Subject: [PATCH] Phosphor widget backward compatibility fix on WidgetRenderer (#3933) --- packages/base/src/widget.ts | 5 +++++ python/jupyterlab_widgets/src/renderer.ts | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/base/src/widget.ts b/packages/base/src/widget.ts index aea060fc8d..a187730d8b 100644 --- a/packages/base/src/widget.ts +++ b/packages/base/src/widget.ts @@ -983,6 +983,11 @@ export class JupyterLuminoPanelWidget extends Panel { private _view: DOMWidgetView; } +/** + * @deprecated Use {@link JupyterLuminoPanelWidget} instead (Since 8.0). + */ +export const JupyterPhosphorPanelWidget = JupyterLuminoPanelWidget; + export class DOMWidgetView extends WidgetView { /** * Public constructor diff --git a/python/jupyterlab_widgets/src/renderer.ts b/python/jupyterlab_widgets/src/renderer.ts index 1e0aa34f37..ce0d257625 100644 --- a/python/jupyterlab_widgets/src/renderer.ts +++ b/python/jupyterlab_widgets/src/renderer.ts @@ -74,7 +74,8 @@ export class WidgetRenderer let widget: LuminoWidget; try { - widget = (await manager.create_view(wModel)).luminoWidget; + const view = await manager.create_view(wModel); + widget = view.luminoWidget || view.pWidget; } catch (err) { this.node.textContent = 'Error displaying widget'; this.addClass('jupyter-widgets');