Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading name print_starting_message #342

Closed
AntoinePrv opened this issue Oct 5, 2022 · 3 comments · Fixed by #388
Closed

Misleading name print_starting_message #342

AntoinePrv opened this issue Oct 5, 2022 · 3 comments · Fixed by #388
Milestone

Comments

@AntoinePrv
Copy link
Member

print_starting_message does not print but returns a string.

std::string print_starting_message(const xconfiguration& config)

@JohanMabille JohanMabille added this to the 4.0 milestone May 29, 2023
@JohanMabille
Copy link
Member

#363 introduces a new get_starting_message and deprecates print_starting_message

@IsabelParedes
Copy link
Member

#363 introduced get_starting_message and get_started_message. The second one is possibly a typo, but which one is preferred?

Or would it be better to have something like get_start_message in v4.0 to avoid confusion?

@JohanMabille
Copy link
Member

@IsabelParedes sorry I missed your comment, get_started_message is indeed a typo. Both other options are fine with me, I let you pick up one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants