ExtensionManager's link_extension() is no longer in sync with nbclassic

[athornton]

Description

ExtensionManager's link_extension() changed its call signature, and nbclassic did not update to follow.

Reproduce

1. Try to load an extension that loads via nbclassic in JupyterLab after
2. [W 2021-09-16 17:55:20.931 SingleUserLabApp manager:349] link_extension() takes 2 positional arguments but 3 were given

Expected behavior

I expected the extension to load.

Context

• JupyterLab version: 3.1.12

Solution

I fixed the method call in nbserver.py. CF #64

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[athornton]

Thanks to @ktlim for figuring out we were going through the nbclassic path and finding the commit where the ExtensionManager interface changed.

[Zsailer]

Fixed in #64 and released in 0.3.2.