sphinx book theme #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
sphinx-book-theme
branch
6 times, most recently
from
d98c056
to
e2be8f2
Compare
MSeal
reviewed
May 7, 2020
tox.ini
Outdated
| @@ -14,17 +14,6 @@ skip_install = true | |||
| deps = check-manifest | |||
| commands = check-manifest | |||
|
|
|||
| # Docs | |||
There was a problem hiding this comment.
I would still like to keep this, as it let's me test that the docs are alright before making PRs
|
Just in the ini file or in Travis as well? |
choldgraf
force-pushed
the
sphinx-book-theme
branch
from
e2be8f2
to
2db2031
Compare
|
(I've just pushed a commit assuming you're OK with keeping it out of travis, but leaving it in the tox file, but lemme know if you'd like it in travis as well) |
|
That works for me, just having the local build helps when doing doc additions. I don't mind as much which tool automates the PR build aspect so long as some tool does. |
|
sounds good - then lemme know if you'd like any extra changes 👍 |
|
LGTM, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the sphinx-book-theme for our documentation. It also adds a CircleCI job to let us preview the built documentation in a PR (and removes the docs job in
toxsince it's redundant now)closes #49
here are the docs: https://4-233653381-gh.circle-artifacts.com/0/html/index.html