From 60b7c22977350bdaa8dda7c8503644c4c632b09e Mon Sep 17 00:00:00 2001 From: Josh Barnes Date: Thu, 16 Nov 2017 01:17:30 +0000 Subject: [PATCH] tidy bidi support remove unused variable, redundant comment, don't need jquery --- notebook/static/bidi/bidi.js | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/notebook/static/bidi/bidi.js b/notebook/static/bidi/bidi.js index 3e7dea272f..9ace652e0a 100644 --- a/notebook/static/bidi/bidi.js +++ b/notebook/static/bidi/bidi.js @@ -5,7 +5,6 @@ define(['bidi/numericshaping'], function(numericshaping) { 'use strict'; var shaperType = ''; - var textDir = ''; var _uiLang = function() { return navigator.language.toLowerCase(); @@ -13,7 +12,7 @@ define(['bidi/numericshaping'], function(numericshaping) { var _loadLocale = function() { if (_isMirroringEnabled()) { - $('body').attr('dir', 'rtl'); + document.body.dir = 'rtl'; } require(['moment'], function (moment) { @@ -27,11 +26,6 @@ define(['bidi/numericshaping'], function(numericshaping) { return new RegExp('^(ar|he)').test(_uiLang()); }; - /** - * NS : for digit Shaping. - * BTD : for future work in case of Base Text Direction Addition. - */ - /** * @param value : the string to apply the bidi-support on it. * @param flag :indicates the type of bidi-support (Numeric-shaping ,Base-text-dir ).