From 7c32c3dd2f1040921b1887d718a5aad768d7f23d Mon Sep 17 00:00:00 2001 From: Francesco Franchina Date: Sat, 18 Nov 2017 00:49:06 +0100 Subject: [PATCH 1/3] Solves part of the #3044 - upload button --- notebook/static/tree/less/altuploadform.less | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/notebook/static/tree/less/altuploadform.less b/notebook/static/tree/less/altuploadform.less index c5798f0c8a..56e3102b65 100644 --- a/notebook/static/tree/less/altuploadform.less +++ b/notebook/static/tree/less/altuploadform.less @@ -13,16 +13,24 @@ input.fileinput { - text-align: center; - vertical-align: middle; - display: inline; + position: absolute; + + display: block; + width: 100%; + height: 100%; + + cursor: pointer; + opacity: 0; z-index: 2; - width: 12ex; - margin-right: -12ex; + } + + .btn-xs > input.fileinput { + margin: -@padding-xs-vertical -@padding-xs-horizontal; } .btn-upload { + position: relative; height: @btn_mini_height; } } From 02e1284d8b6abdddaecf6aacf2240637f1949dbd Mon Sep 17 00:00:00 2001 From: Francesco Franchina Date: Sat, 18 Nov 2017 01:36:39 +0100 Subject: [PATCH 2/3] Fixes completely #3044 - select all --- notebook/static/tree/less/tree.less | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/notebook/static/tree/less/tree.less b/notebook/static/tree/less/tree.less index 518dc72a67..38fc1a954d 100644 --- a/notebook/static/tree/less/tree.less +++ b/notebook/static/tree/less/tree.less @@ -125,7 +125,7 @@ ul.breadcrumb { input { margin-right: @dashboard_lr_pad; margin-left: @dashboard_lr_pad + @dashboard-selectorbtn-lpad; - vertical-align: baseline; + vertical-align: text-bottom; line-height: @btn_mini_height; position: relative; top: -1px; @@ -256,6 +256,9 @@ ul.breadcrumb { #select-all { margin-left: @dashboard_lr_pad; margin-right: 2px; + margin-top: 2px; + + height: 16px; } [dir="rtl"] #select-all.pull-left { From 47a6401ea04b5b65a3a742680390c431a2d6e059 Mon Sep 17 00:00:00 2001 From: Francesco Franchina Date: Sun, 19 Nov 2017 00:24:07 +0100 Subject: [PATCH 3/3] Forced the the cursor as a pointer hovering the fileinput - chrome only --- notebook/static/tree/less/altuploadform.less | 2 ++ 1 file changed, 2 insertions(+) diff --git a/notebook/static/tree/less/altuploadform.less b/notebook/static/tree/less/altuploadform.less index 56e3102b65..074d0cca6e 100644 --- a/notebook/static/tree/less/altuploadform.less +++ b/notebook/static/tree/less/altuploadform.less @@ -34,3 +34,5 @@ height: @btn_mini_height; } } + +::-webkit-file-upload-button { cursor:pointer; }