Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup GitHub Action to automatically update the Playwright snapshots #6690

Closed
jtpio opened this issue Jan 12, 2023 · 1 comment · Fixed by #6723 or #6724
Closed

Setup GitHub Action to automatically update the Playwright snapshots #6690

jtpio opened this issue Jan 12, 2023 · 1 comment · Fixed by #6723 or #6724
Labels
maintenance
Milestone
Future

Comments

@jtpio
Copy link
Member

jtpio commented Jan 12, 2023

Currently the UI Tests snapshots must be updated manually.

JupyterLab and other projects are using a GitHub Action to do this more easily by just posting a comment on the PR, with https://github.com/jupyterlab/maintainer-tools#update-snapshots.

We should setup similar here in this repo.
@jtpio jtpio added this to the 7.0 milestone Jan 12, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Jan 12, 2023
@jtpio jtpio added maintenance and removed status:Needs Triage Applied to issues that need triage labels Jan 12, 2023
@jtpio jtpio modified the milestones: 7.0, Future Jan 12, 2023
@jtpio jtpio mentioned this issue Feb 9, 2023
Merged
@jtpio
Copy link
Member Author

jtpio commented Feb 9, 2023

Reopening as there are still some issues being investigated in #6724

@jtpio jtpio reopened this Feb 9, 2023
@jtpio jtpio mentioned this issue Feb 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
Future
1 participant
@jtpio