Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi cursors missing in notebook v7 ? #6820

Closed
Carreau opened this issue Apr 5, 2023 · 3 comments
Closed

Multi cursors missing in notebook v7 ? #6820

Carreau opened this issue Apr 5, 2023 · 3 comments

Comments

@Carreau
Copy link
Member

Carreau commented Apr 5, 2023

It looks like having multiple cursor is gone in notebook 7, is that on purpose ? I'm guessing due to a difference codemirror version ?

@Carreau Carreau added the bug label Apr 5, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Apr 5, 2023
@RRosio
Copy link
Collaborator

RRosio commented Apr 11, 2023

Hi @Carreau, I am not familiar with the multiple cursor, would you mind providing an example?

@Carreau
Copy link
Member Author

Carreau commented Apr 12, 2023

Here you go,

Screen.Recording.2023-04-12.at.11.14.34.mov

Ctrl/Cmd on mac, this seem to be related to jupyterlab/jupyterlab#14105 ?

Edit: I realize it's not obvious from the video, but with Ctrl-click you can but cursor anywhere, like for example Ctrl-Double-click on multiple token to rename them.

@jtpio
Copy link
Member

jtpio commented May 15, 2023

Closing as this appears to be fixed in 7.0.0b2 now (likely grabbed the fix from JupyterLab during one of the updates):

notebook-multi-cursor.mp4

@jtpio jtpio closed this as completed May 15, 2023
@jtpio jtpio modified the milestones: 7.0.x, 7.0 May 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants