Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jlpm watch is not working when making changes to Notebook codebase #6846

Closed
andrii-i opened this issue Apr 19, 2023 · 6 comments
Closed

jlpm watch is not working when making changes to Notebook codebase #6846

andrii-i opened this issue Apr 19, 2023 · 6 comments
Labels
bug status:Answered status:Needs Triage Applied to issues that need triage

Comments

@andrii-i
Copy link
Contributor

andrii-i commented Apr 19, 2023

Describe the bug
jlpm watch is not working when making changes to Notebook codebase. For changes to propagate, I need to call jlpm build every time

To Reproduce
Steps to reproduce the behavior:

  1. Follow Setting up a development environment section of CONTRIBUTING.md (note that jlpm develop also fails but this might be due to the fact that I'm trying to change Notebook codebase, not develop a Notebook extension?)
  2. Launch Notebook instance and attempt to make a change in Notebook codebase
  3. Note how change would not propagate until jlpm build is called

Expected behavior
When using jlpm watch, rebuild is triggered automatically on any change

  • OS: Apple M1 Pro, Ventura 13.3.1
  • Browser: Chrome Version 112.0.5615.121 (Official Build) (arm64)
  • Version: head-of-master
@andrii-i andrii-i added the bug label Apr 19, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Apr 19, 2023
@jtpio
Copy link
Member

jtpio commented Apr 20, 2023

Thanks @andrii-i for reporting.

I just checked with a fresh environment on Gitpod and it seems to be working fine:

watch-command.mp4

image

Maybe it's an issue on how files are watched on MacOS?

@andrii-i
Copy link
Contributor Author

Thank you @jtpio, let me look more into this, may also be a problem with my local environment

@JasonWeill
Copy link
Collaborator

@andrii-i Can you please update or close out if the issue is limited to your local env?

@krassowski
Copy link
Member

Could it be due to a problematic jupyterlab-server version in your environment, c-f jupyterlab/jupyterlab_server#356?

@andrii-i
Copy link
Contributor Author

Closing as suggested

@andrii-i
Copy link
Contributor Author

Thank you everyone for the feedback

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:Answered status:Needs Triage Applied to issues that need triage
Projects
None yet
Development

No branches or pull requests

4 participants