Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very poor navigation in new readthedocs builds #6848

Open
ericsnekbytes opened this issue Apr 20, 2023 · 6 comments
Open

Very poor navigation in new readthedocs builds #6848

ericsnekbytes opened this issue Apr 20, 2023 · 6 comments

Comments

@ericsnekbytes
Copy link
Collaborator

ericsnekbytes commented Apr 20, 2023

Since the navigation and structure of new readthedocs builds is very poor, we should revert to the previous standard readthedocs theme (and move any in-progress work to a branch) until the issues noted below can be fixed:

image

image

image

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Apr 20, 2023
@jtpio
Copy link
Member

jtpio commented Apr 20, 2023

Since the navigation and structure of new readthedocs builds is very poor,

What does "new readthedocs builds" mean in this context?

The ReadTheDocs setup on the main branch has not changed for quite a while. It's using the same setup as most of the other projects with the pydata-sphinx-theme (like JupyterLab: https://jupyterlab.readthedocs.io/en/latest/).

@ericsnekbytes
Copy link
Collaborator Author

This page/link (stable) is the first result for "jupyterlab install" on google, which I believe uses sphinx-rtd-theme.

@ericsnekbytes
Copy link
Collaborator Author

It looks like many of the same issues are present there also, which makes me want to open a lab issue or combine them.

@ericsnekbytes
Copy link
Collaborator Author

ericsnekbytes commented Apr 20, 2023

The best way forward in both cases I think is to revert to the old theme (if this can be done with fairly minimal changes to the conf.py/related settings), develop changes in a new branch, then merge once navigation/structure issues are resolved. Edit: Reverting to sphinx-rtd-theme would be preferable so that this design does not end up in front of users (popular links are pointing to the classic theme), these are major readability/usability problems that are going to negatively impact docs users (and harm the jupyter experience/community).

@jtpio
Copy link
Member

jtpio commented Apr 20, 2023

Edit: Reverting to sphinx-rtd-theme would be preferable so that this design does not end up in front of users (popular links are pointing to the classic theme), these are major readability/usability problems that are going to negatively impact docs users (and harm the jupyter experience/community).

Not sure this opinion is shared by everyone. The trend has been to adopt sphinx-pydata-theme over the past years, which has the nice benefit of giving a consistent look to the whole PyData ecosystem. It doesn't look like there have been a lot of complaints so far, does it?

Numpy uses it:

image

Pandas as well:

image

Probably a lot more in the PyData world.

and harm the jupyter experience/community

Not sure this holds true given that there is:

revert to the old theme

Reverting the docs, and then switching again later will add unnecessary work to the already small crew of maintainers of the jupyter/notebook repo.

Instead wouldn't it be possible to suggest incremental improvements via pull requests? It looks like their documentation is very complete: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/index.html

Also as an example the ipywidgets documentation has the left navigation bar displayed on the front page: https://ipywidgets.readthedocs.io/en/stable. Maybe this could be enabled on the notebook documentation as well? That could help address one of the points above.

@ericsnekbytes
Copy link
Collaborator Author

ericsnekbytes commented Apr 20, 2023

I can see that the theme change is global to the Jupyter org. I'll work on a focused PR to remedy some of the navigation issues. There's probably some rework that could be done around usage of the top and left bar and table-of-contents/summary pages that will help a lot. Edit: It seems like the numpy docs most successfully make use of the new theme, there are definitely some cues I can take from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants