-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very poor navigation in new readthedocs builds #6848
Comments
What does "new readthedocs builds" mean in this context? The ReadTheDocs setup on the |
This page/link (stable) is the first result for "jupyterlab install" on google, which I believe uses |
It looks like many of the same issues are present there also, which makes me want to open a lab issue or combine them. |
The best way forward in both cases I think is to revert to the old theme (if this can be done with fairly minimal changes to the conf.py/related settings), develop changes in a new branch, then merge once navigation/structure issues are resolved. Edit: Reverting to |
Not sure this opinion is shared by everyone. The trend has been to adopt Numpy uses it: Pandas as well: Probably a lot more in the PyData world.
Not sure this holds true given that there is:
Reverting the docs, and then switching again later will add unnecessary work to the already small crew of maintainers of the Instead wouldn't it be possible to suggest incremental improvements via pull requests? It looks like their documentation is very complete: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/index.html Also as an example the ipywidgets documentation has the left navigation bar displayed on the front page: https://ipywidgets.readthedocs.io/en/stable. Maybe this could be enabled on the notebook documentation as well? That could help address one of the points above. |
I can see that the theme change is global to the Jupyter org. I'll work on a focused PR to remedy some of the navigation issues. There's probably some rework that could be done around usage of the top and left bar and table-of-contents/summary pages that will help a lot. Edit: It seems like the numpy docs most successfully make use of the new theme, there are definitely some cues I can take from there. |
Since the navigation and structure of new readthedocs builds is very poor, we should revert to the previous standard readthedocs theme (and move any in-progress work to a branch) until the issues noted below can be fixed:
The text was updated successfully, but these errors were encountered: