Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings failed to load error in the dev tools console #7062

Open
jtpio opened this issue Sep 19, 2023 · 12 comments
Open

Settings failed to load error in the dev tools console #7062

jtpio opened this issue Sep 19, 2023 · 12 comments
Labels

Comments

@jtpio
Copy link
Member

jtpio commented Sep 19, 2023

Currently seeing this error on the dev tools console on the latest main:

image

Settings failed to load for (@jupyterlab/metadataform-extension:metadataforms) 

And

Settings failed to load for (@jupyterlab/cell-toolbar-extension:plugin)
@jtpio jtpio added bug status:Needs Triage Applied to issues that need triage labels Sep 19, 2023
@jtpio
Copy link
Member Author

jtpio commented Sep 19, 2023

cc @brichet who might know more about this and whether this is related to a change upstream in JupyterLab

@jtpio
Copy link
Member Author

jtpio commented Sep 19, 2023

The messages seem to originate from the following:

app.restored.then(async () => {
const plugins = await connector.list('all');
plugins.ids.forEach(async (id: string) => {
const [extension] = id.split(':');
// load the plugin if it is built-in the notebook application explicitly
// either included as an extension or as a plugin directly
const hasPlugin = pluginsSet.has(extension) || pluginsSet.has(id);
if (!hasPlugin || isDisabled(id) || id in settingRegistry.plugins) {
return;
}
try {
await settingRegistry.load(id);
} catch (error) {
console.warn(`Settings failed to load for (${id})`, error);
}
});
});

@brichet
Copy link
Contributor

brichet commented Sep 19, 2023

I can't find any related changes in Jupyterlab.
Do you know if this warning was not present in previous versions ?

The settingRegistry.load function seems to fail when the plugin is not activated.
For me it is expected, the Notebook plugins are not loaded in the tree view (so not the metadataform and cell toolbar either).
But these plugins should probably not be in the pluginSet variable.

@jtpio
Copy link
Member Author

jtpio commented Sep 19, 2023

For me it is expected, the Notebook plugins are not loaded in the tree view (so not the metadataform and cell toolbar either).

This logic was added so the plugins not activated on the tree page would still show up in the settings editor (which is only available on the tree page): #6750

@brichet
Copy link
Contributor

brichet commented Sep 19, 2023

I don't think it can work for plugins with a transformation function, since these functions are registered on plugin activation.
Both warnings concern plugins with a transformation function.
The only recent related PR I can see is jupyterlab/jupyterlab#14990, but AFAIK it couldn't work before.

It seems that the message was already present with previous releases of Notebook:

@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Sep 19, 2023
@jtpio
Copy link
Member Author

jtpio commented Sep 19, 2023

Thanks @brichet for the details 👍

The only recent related PR I can see is jupyterlab/jupyterlab#14990, but AFAIK it couldn't work before.

Yeah I saw a couple of PRs on JupyterLab that could have been related, but they are not backported to 4.0.x so not used in Notebook 7 (for now).

@jtpio
Copy link
Member Author

jtpio commented Sep 28, 2023

Maybe we should open the settings editor in one of the side panels instead of the file browser page (like the extension manager).

That way it would pick up the plugins loaded on the current page, and would not require having to load them explicitly.

@brichet
Copy link
Contributor

brichet commented Sep 28, 2023

This should work for loading settings, but the panel is quite large with the current display. It can be difficult to navigate if it's in a side panel.

@capey0
Copy link

capey0 commented Apr 12, 2024

In the latest version of Chrome devtools console:

I get 100s of the following:
"Skipping this shortcut because there are no actionable keys on this platform" issued from 5649.bundle.js

Then I get the same messages as OP (except they are from 3768.bundle.js)

I am using:
Windows 11
Python 3.12.x
Used "pip3 install ..." to get Jupyter
Jupyter Dark theme
NO Anaconda

The result is the "increase/decrease font sizes" in the menus do not work. The color schemes for highlighting different data types and keywords also does not work.

Forgot to mention "auto-formatting" (eg. inserting a tab when needed), also does not work!
:(

@capey0
Copy link

capey0 commented Apr 18, 2024

This morning I opened up Jupyter Notebook and the keyword colorization seems to be working and so does the indenting. However, I now see this in the dev window when I try to change the font size:
image

I am still getting 100s of "Skipping ..." messages

@capey0
Copy link

capey0 commented Apr 24, 2024

Ok, frankly this sucks! The colorization has disappeared and so has the indenting.

Still getting all the above messages.

:(!

@capey0
Copy link

capey0 commented May 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants