-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Add nbresuse==0.3.3 (full freeze.py) #904
Conversation
I think this will be a useful addition. Going to wait and see if someone else has an opinion. On a meta level it makes me wonder if we should start thinking about "repo2docker" and "repo2docker binderhub style". The latter would be r2d + all the custom extensions and packages we are adding that are useful when running in a BinderHub. Or maybe it isn't needed as most people use repo2docker via a BinderHub any way. |
It looks like Travis is failing on Python 2.7:
which may be due to the change to wcwidth: - - wcwidth=0.1.8=py_0
+ - wcwidth=0.2.3=pyh9f0ad1d_0 Upstream diff: jquast/wcwidth@0.1.8...0.2.3 |
For comparison I've also got a separate branch with a minimal commit that only adds |
Seems like a bug in |
Later versions of wcwidth require `backports.functools-lru-cache>=1.2.1; python_version < "3.2"` but the conda-forge wcwidth package was automatically bumped without this new requirement.
I think it's a bug in the conda-forge wcwidth package (upstream added a new dependency for python<3.2 which is missing from the conda package), I've pinned it for Python 2.7 only. The remaining CI failure looks unrelated. |
Restarted the CI. It seems sometimes the "does the memory limit work" tests fail. It seems like some of the nodes our tests run on support it and some don't :-/ |
@manics thanks for adding this! may I ask why you didnt add v0.3.4 instead? I mead, did you simply miss it or is there a specific reason? I am just curious :) |
okay, v0.3.4 has a problem with jupyterlab: jupyter-server/jupyter-resource-usage#36 |
Adds
nbresuse==0.3.3
, followed by runningfreeze.py
JupyterLab automatically displays the metrics provided by nbresuse, it doesn't need a separate extension. Note that as mentioned in jupyterhub/binderhub#1097 (comment) there are alternative JupyterLab front-ends for nbresuse, for instance https://github.com/jtpio/jupyterlab-system-monitor
Closes jupyterhub/binderhub#1097
Screenshots from testing locally with
docker run -e MEM_LIMIT=200000000 ...
Notebook:
Lab: