From 35c603491756ffd274f342e23a45eb6fda04f756 Mon Sep 17 00:00:00 2001
From: Thomas VINCENT <thomas.vincent@esrf.fr>
Date: Mon, 30 Jan 2023 15:33:37 +0100
Subject: [PATCH] Add some tests for req_output

---
 batchspawner/tests/test_spawners.py | 34 +++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/batchspawner/tests/test_spawners.py b/batchspawner/tests/test_spawners.py
index bd378c5..6005ae0 100644
--- a/batchspawner/tests/test_spawners.py
+++ b/batchspawner/tests/test_spawners.py
@@ -481,6 +481,40 @@ async def test_slurm(db, event_loop):
         re.compile(r"^\#SBATCH \s+ some_option_asdf", re.X | re.M),
         re.compile(r"^\#SBATCH \s+ --reservation=RES123", re.X | re.M),
         re.compile(r"^\#SBATCH \s+ --gres=GRES123", re.X | re.M),
+        re.compile(
+            r"^\#SBATCH \s+ --output= .+ /jupyterhub_slurmspawner_%j.log", re.X | re.M
+        ),
+    ]
+    from .. import SlurmSpawner
+
+    await run_spawner_script(
+        db,
+        SlurmSpawner,
+        normal_slurm_script,
+        batch_script_re_list=batch_script_re_list,
+        spawner_kwargs=spawner_kwargs,
+    )
+
+
+@pytest.mark.parametrize(
+    "req_output,expected_file_pattern",
+    [
+        ("/dev/null", "/dev/null"),
+        ("slurm-%j.out", "{homedir}/slurm-%j.out"),
+    ],
+)
+async def test_slurm_req_output(db, event_loop, req_output, expected_file_pattern):
+    homedir = "/users/jhub_users"
+    spawner_kwargs = {
+        "req_output": req_output,
+        "req_homedir": homedir,
+    }
+
+    batch_script_re_list = [
+        re.compile(
+            r"^\#SBATCH \s+ --output=" + expected_file_pattern.format(homedir=homedir),
+            re.X | re.M,
+        ),
     ]
     from .. import SlurmSpawner