-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Docker Hub registry usage #902
Comments
Potentiall related to #205. Configuration probably goes into
|
These are the parts related to docker hub in the "next section":
These settings are what we use in GESIS binder and should be enough to use docker hub registry. secret.yaml: registry:
username: <docker-id>
password: <password> config.yaml: config:
BinderHub:
use_registry: true
image_prefix: <docker-id OR organization-name>/<prefix>- |
Well, then it was just a confusion about what "next" means. I'll prepare a PR that turns "next section" into a link to "3. Set up BinderHub". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I hope I'm not missing something, but I think the documentation for using the DockerHub registry is incomplete. Or is
docker login
all there is needed? I assume not, because I probably need to configure the org-option that is mentioned.The tests in https://github.com/jupyterhub/binderhub/blob/master/binderhub/tests/test_registry.py use different options (token, usename/password).
Screenshot of https://binderhub.readthedocs.io/en/latest/setup-registry.html#set-up-docker-hub-registry where the "next section" is not what is promised :-)
The text was updated successfully, but these errors were encountered: