Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests for jupyterhub 5 #246

Closed
consideRatio opened this issue Sep 12, 2024 · 1 comment · Fixed by #269
Closed

Fix broken tests for jupyterhub 5 #246

consideRatio opened this issue Sep 12, 2024 · 1 comment · Fixed by #269
Assignees
@minrk

Comments

@consideRatio
Copy link
Member

I think maybe its related to allow_all config? Maybe not? For reference, see also: jupyterhub/firstuseauthenticator#56.
This was referenced Sep 12, 2024
Closed
Merged
Closed
@minrk minrk self-assigned this Sep 17, 2024
@minrk
Copy link
Member

minrk commented Sep 17, 2024

Pretty sure this is due to allow_all config and the fact that allowed_groups is checked in authenticate and not check_allowed.

@minrk minrk mentioned this issue Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minrk minrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

align allowed_groups with other allowed_ config, consistent in JupyterHub 5 minrk/ldapauthenticator
2 participants
@minrk @consideRatio