Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A co-ordinated welcome effort on first merged PR in our org #391

Closed
consideRatio opened this issue Mar 22, 2021 · 11 comments
Closed

A co-ordinated welcome effort on first merged PR in our org #391

consideRatio opened this issue Mar 22, 2021 · 11 comments

Comments

@consideRatio
Copy link
Member

consideRatio commented Mar 22, 2021

TL;DR
To let automation help us identify when a person is new to the JupyterHub org and provide a explicit warm and human welcome, perhaps for example by having a bot tag a welcome team the first time a person gets merged PR or similar?

@jupyterhub/jupyterhubteam sometimes a person gets their first PR merged within our organisation. I think that is worth some extra celebration, so what do you think about having a bot that mentions either the @jupyterhub/jupyterhubteam or a dedicated JupyterHub org team for welcoming and congratulating that person?

I have never seen that before, but wouldn't it be quite nice? To gather everyone in order to welcome someone actively for their first contribution in our org? Perhaps the team could also be Jupyter wide rather than JupyterHub wide? I think it could make sense to do this Jupyter wide now that I think of it, across a collection of organizations that opt-in to it.

Today I learned

I have used the word love bombing without understanding its connotations. I assumed it was the act of putting in some additional effort to show love/appreciation/etc for someone, but I think the term love bombing can mean to do so with a bad intent.

@minrk
Copy link
Member

minrk commented Mar 22, 2021

I think our current welcome bot does this on a per-repo basis, and this seems pretty nice to me. I'm not sure doing more based on org-level information would be better or not.

@consideRatio
Copy link
Member Author

@minrk I'd like to retain the per-repo system but to augment it with a per-org first time ever non-automated welcome effort, perhaps for a merged PR as opened issue/opened PR would lead to too much noise I think.

@betatim
Copy link
Member

betatim commented Mar 22, 2021

What is the thing/problem that would be fixed by doing this?

@consideRatio
Copy link
Member Author

@betatim thanks for the question, it enabled me to think a bit more explicitly about it!

The goal of having a "human welcome party" happen the first time a "new contributor" (gets a PR merged within our org?), is for example to:

  • Give the new contributor a positive experience about contributing to our org
  • Provide the voluntary welcoming team with a good reason to be happy together
  • Help the new contributor establish some connection with more active people in the org
    • This could help the new contributor dare to reach out to other contributors and not only the ones involved in reviewing/merging that specific first PR merged

@manics
Copy link
Member

manics commented Mar 22, 2021

I don't think we need a per-repo and a per-org post- if they are too many friendly bot replies it devalues them.

I see the value in encouraging new contributors to Jupyter*, and I like the suggestion from @consideRatio of "Perhaps the team could also be Jupyter wide rather than JupyterHub wide?". With this in mind perhaps we should discuss this more openly on Discourse, especially as submitting a PR is only one form of contribution, but if we only "welcome" PR contributors that elevates them above the rest.

My gut feeling from observing the JupyterHub repos is that although there are outstanding unimplemented features and unfixed bugs (and always will be!) we're not really lacking in PRs. We're more lacking in the time to review them, or to investigate potential bugs, or to take charge of a discussion and encourage people to come to a consensus. If we were to focus on onboarding new contributors I'd think we'd get more benefit from encouraging the latter than focussing on code submissions.

@consideRatio
Copy link
Member Author

@manics the per-org response that I suggest wouldn't need to have any bot involvement visible for the user that is welcomed. It could simply be a hidden notification to other users that the contributor is a new contributor in a separate communication channel for example.

Discourse is developed to help community grow and foster a good culture, and have these "this is the first post for this user" notices that show for those that are more experienced in the forum. I guess what I'm looking for is something like this in practice, some way to help us provide some human encouragement.

@yuvipanda
Copy link
Collaborator

FWIW, @rgbkrk did this for me when I first contributed, and it really really really really helped me stick around :)

@rkdarst
Copy link

rkdarst commented Mar 22, 2021 via email

@consideRatio
Copy link
Member Author

This was also my experience, that the positive encouragement early on had a significant impact on me. I guess it also modelled a behavior that I could adopt.

I recall research that acts of kindness and friendly gestures etc can propagate, just like a friendly smile and eye contact can make you smile when you meet a person short thereafter etc because the positive feeling lingered.

@choldgraf
Copy link
Member

choldgraf commented Mar 22, 2021

I agree that a human interaction is much more meaningful than a robot interaction 👍

Perhaps this kind of thing could be either carried out, or at least use some thinking and planning, by a "community advocate" role as described in #380 ?

@consideRatio
Copy link
Member Author

I think we concluded that having a personal thanks is a big deal compared to having a bot.

We have a bot as well now, and that in turn has helped at least me realize who is a new contributor etc. Let's go for a close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants