From c0c273b0c851f19bc34e890f7c67190cc52e88ab Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Tue, 5 Sep 2023 04:47:52 -0500 Subject: [PATCH] cleanup --- tests/data/npm_builder/myextension/package.json | 3 +-- tests/data/npm_builder/myextension/src/index.ts | 17 +---------------- .../data/npm_builder/myextension/tsconfig.json | 1 + 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/tests/data/npm_builder/myextension/package.json b/tests/data/npm_builder/myextension/package.json index f5d6574..f143f2c 100644 --- a/tests/data/npm_builder/myextension/package.json +++ b/tests/data/npm_builder/myextension/package.json @@ -54,8 +54,7 @@ "watch:labextension": "jupyter labextension watch ." }, "dependencies": { - "@jupyterlab/application": "^3.1.0", - "@jupyterlab/settingregistry": "^3.1.0" + "@jupyterlab/application": "^3.1.0" }, "devDependencies": { "@jupyterlab/builder": "^3.1.0", diff --git a/tests/data/npm_builder/myextension/src/index.ts b/tests/data/npm_builder/myextension/src/index.ts index e5a9c8b..353d021 100644 --- a/tests/data/npm_builder/myextension/src/index.ts +++ b/tests/data/npm_builder/myextension/src/index.ts @@ -3,31 +3,16 @@ import { JupyterFrontEndPlugin } from '@jupyterlab/application'; -import { ISettingRegistry } from '@jupyterlab/settingregistry'; - /** * Initialization data for the myextension extension. */ const plugin: JupyterFrontEndPlugin = { id: 'myextension:plugin', autoStart: true, - optional: [ISettingRegistry], activate: ( - app: JupyterFrontEnd, - settingRegistry: ISettingRegistry | null + app: JupyterFrontEnd ) => { console.log('JupyterLab extension myextension is activated!'); - - if (settingRegistry) { - settingRegistry - .load(plugin.id) - .then(settings => { - console.log('myextension settings loaded:', settings.composite); - }) - .catch(reason => { - console.error('Failed to load settings for myextension.', reason); - }); - } } }; diff --git a/tests/data/npm_builder/myextension/tsconfig.json b/tests/data/npm_builder/myextension/tsconfig.json index 0d36199..cdb3eca 100644 --- a/tests/data/npm_builder/myextension/tsconfig.json +++ b/tests/data/npm_builder/myextension/tsconfig.json @@ -15,6 +15,7 @@ "resolveJsonModule": true, "outDir": "lib", "rootDir": "src", + "skipLibCheck": true, "strict": true, "strictNullChecks": true, "target": "es2018",