You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a collaborator is still typing into an RTC notebook or just finished typing within 1 second, if another collaborator attempts to close this notebook from their JupyterLab view, a dialog window or pop up window will show up to the user to block closing the file. This experience is pretty clunky.
If clicking save as and choose same file name, it will pop up a dialog saying difference between file on disk and this file.
Reproduce
This problem can be reproduce in a collaboration setting AND by a singer user:
Single user (A) case:
Open a notebook file and type in some words.
After finishing typing, within 1 seconds, try to close the notebook file.
You will see the a pop up.
Two user case:
If also have another collaborator user B,
Open a notebook file together
User B keeps typing the same letter repeatedly.==
User A try to close the file
User A will see this pop up window as long as User B is typing. If User A follow the dialog and overwrite the change in disk with notebook file change, it might cause User B to lose content that User B just typed in.
Expected behavior
User should be able to close file without seeing a pop up. No changes should ever be lost.
Suspects
There is a save_interval delay between notebook file is changed and persisting it to disk. I think a separate call to the Contents REST API must be happening when the document is close? This would cause competing "saves".
When user happens to close the file at that time, a content difference is detected between these competing "save" calls and leads to the pop up.
The text was updated successfully, but these errors were encountered:
Description
When a collaborator is still typing into an RTC notebook or just finished typing within 1 second, if another collaborator attempts to close this notebook from their JupyterLab view, a dialog window or pop up window will show up to the user to block closing the file. This experience is pretty clunky.
If clicking save as and choose same file name, it will pop up a dialog saying difference between file on disk and this file.
Reproduce
This problem can be reproduce in a collaboration setting AND by a singer user:
Single user (A) case:
Two user case:
If also have another collaborator user B,
Expected behavior
User should be able to close file without seeing a pop up. No changes should ever be lost.
Suspects
There is a save_interval delay between notebook file is changed and persisting it to disk. I think a separate call to the Contents REST API must be happening when the document is close? This would cause competing "saves".
When user happens to close the file at that time, a content difference is detected between these competing "save" calls and leads to the pop up.
The text was updated successfully, but these errors were encountered: