Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A YRoom can be created from an un-authenticated user. #291

Open
Zsailer opened this issue Apr 18, 2024 · 1 comment
Open

A YRoom can be created from an un-authenticated user. #291

Zsailer opened this issue Apr 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Zsailer
Copy link
Member

Zsailer commented Apr 18, 2024

I noticed while investigating #290 that an unauthenticated user can trigger the creation of a collaborative document, even they are blocked from connecting to it after it is created.

I believe the issue is that authentication happens in the parent class's prepare(...) method in the YDocWebSocketHandler, which is called after the room is created.

I think we need to move this call earlier in this method, probably call it first before any other logic.

@krassowski
Copy link
Member

@Zsailer was this resolved by #289? It looks like it was but it seems no test was added so probably fine to keep this issue but rename to "add a test for ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants