Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Support @jupyter/ydoc 2.x #316

Conversation

fcollonval
Copy link
Member

Fixes #309

@jupyter/ydoc 2.x is identical to 1.x - the major bump was a consequence of a change in the Python package.

Copy link
Contributor

Binder 👈 Launch a Binder on branch fcollonval/jupyter_server_ydoc/309-211-shows-jupyterlab-compatibility-warning-with-jupyterlab-42

@fcollonval fcollonval changed the base branch from main to 2.x May 31, 2024 08:35
@fcollonval fcollonval changed the title Support @jupyter/ydoc 2.x [2.x] Support @jupyter/ydoc 2.x May 31, 2024
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fred.

@fcollonval fcollonval added the bug Something isn't working label May 31, 2024
@fcollonval
Copy link
Member Author

On Binder build, the result of jupyter labextension list is

+ jupyter labextension list
JupyterLab v4.2.1
/srv/conda/envs/notebook/share/jupyter/labextensions
        jupyter-offlinenotebook v0.2.2 enabled  X
        jupyterlab_pygments v0.3.0 enabled OK (python, jupyterlab_pygments)
        @jupyter-widgets/jupyterlab-manager v5.0.10 enabled OK (python, jupyterlab_widgets)
        @jupyter-server/resource-usage v1.0.2 enabled OK (python, jupyter-resource-usage)
        @jupyter/collaboration-extension v2.1.1 enabled OK (python, jupyter_collaboration)


   The following extensions may be outdated or specify dependencies that are incompatible with the current version of jupyterlab:
        jupyter-offlinenotebook
        
   If you are a user, check if an update is available for these packages.
   If you are a developer, re-run with `--verbose` flag for more details.


Disabled extensions:
    @jupyterlab/filebrowser-extension:defaultFileBrowser

@davidbrochart
Copy link
Collaborator

Failures seem to be caused by the latest release of AnyIO. In this PR, AnyIO now emits a ResourceWarning on unclosed memory object streams. So we should either explicitly close memory object streams (best) or ignore this warning in tests.

@davidbrochart
Copy link
Collaborator

This is happening in pycrdt-websocket.
Another (temporary) option would be to pin anyio <4.4.0.

@fcollonval fcollonval marked this pull request as ready for review May 31, 2024 12:18
@fcollonval
Copy link
Member Author

Failures seem to be caused by the latest release of AnyIO. In this PR, AnyIO now emits a ResourceWarning on unclosed memory object streams. So we should either explicitly close memory object streams (best) or ignore this warning in tests.

Thanks for highlighting the source of the error. I add the new warning to the ignore list of pytest in 4a311c7.

@davidbrochart
Copy link
Collaborator

Thanks. I guess we should update the screenshots in the UI tests, as we did in 3.x?

@davidbrochart
Copy link
Collaborator

@fcollonval there are conflicts, sorry for not merging earlier. Do you want to rebase?

@brichet
Copy link
Contributor

brichet commented Oct 18, 2024

@fcollonval I can rebase it if you want, I also need this compatibility.

@fcollonval
Copy link
Member Author

@fcollonval I can rebase it if you want, I also need this compatibility.

Thanks @brichet please feel free to do so. My oss bandwidth is tight currently.

@brichet brichet force-pushed the 309-211-shows-jupyterlab-compatibility-warning-with-jupyterlab-42 branch from 4a311c7 to 51a236b Compare October 18, 2024 12:02
@brichet
Copy link
Contributor

brichet commented Oct 21, 2024

Failing tests seem not related to this PR.

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@davidbrochart davidbrochart merged commit 80dd8c1 into jupyterlab:2.x Oct 22, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1.1 shows jupyterlab compatibility warning with jupyterlab 4.2
3 participants