-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Support @jupyter/ydoc 2.x #316
[2.x] Support @jupyter/ydoc 2.x #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Fred.
On Binder build, the result of
|
Failures seem to be caused by the latest release of AnyIO. In this PR, AnyIO now emits a |
This is happening in |
Thanks for highlighting the source of the error. I add the new warning to the ignore list of pytest in 4a311c7. |
Thanks. I guess we should update the screenshots in the UI tests, as we did in |
@fcollonval there are conflicts, sorry for not merging earlier. Do you want to rebase? |
@fcollonval I can rebase it if you want, I also need this compatibility. |
Thanks @brichet please feel free to do so. My oss bandwidth is tight currently. |
4a311c7
to
51a236b
Compare
Failing tests seem not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Fixes #309
@jupyter/ydoc 2.x is identical to 1.x - the major bump was a consequence of a change in the Python package.