Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash to check if the file has changed on disk #340

Open
krassowski opened this issue Aug 22, 2024 · 0 comments
Open

Use hash to check if the file has changed on disk #340

krassowski opened this issue Aug 22, 2024 · 0 comments

Comments

@krassowski
Copy link
Member

krassowski commented Aug 22, 2024

Now that we use the file hash, we could use it to check if the server was the one who saved the file last, instead of using timestamps (see jupyter-server/jupyter_server#1367 (comment) and jupyterlab/jupyterlab#14031 (comment)). This could be done in another PR.

Originally posted by @davidbrochart in #337 (comment)

Upstream JupyterLab checks hash if present and if not then falls back to timestamp comparison. There are some cases when hash is better because touching file when changing branches or similar (but keeping the content the same) does change timestamp but not the hash. hash is only available with newer jupyter-server (2.11.1 or newer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant