Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for compatibility with JupyterLab 3 #23

Closed
5 tasks done
3coins opened this issue Mar 14, 2022 · 8 comments · Fixed by #24
Closed
5 tasks done

Update for compatibility with JupyterLab 3 #23

3coins opened this issue Mar 14, 2022 · 8 comments · Fixed by #24
Labels
enhancement New feature or request

Comments

@3coins
Copy link
Collaborator

3coins commented Mar 14, 2022

Problem

The current stable version of JupyterLab is 3.x, which is incompatible with the telemetry package.

Proposed Solution

Update dependencies and code to make it compatible with JupyterLab 3.

  • Update jupyterlab dependencies to 3.3.x
  • Replace phosphor dependencies with lumino
  • Update typescript to 4.8.1
  • Update dev dependencies
  • Update code for successful build
@3coins 3coins added the enhancement New feature or request label Mar 14, 2022
@welcome
Copy link

welcome bot commented Mar 14, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@3coins
Copy link
Collaborator Author

3coins commented Mar 14, 2022

@yuvipanda @Zsailer @blink1073
I am planning to work on this issue, but wanted to understand the amount of effort required for this. Can one of you please help evaluate this?
Other than upgrading the dependencies and JS code, is there any server extension code that would change significantly here? Would it be better to start with an empty cookie cutter pre-built extension and move code from this package?

Thanks for your help.

@yuvipanda
Copy link
Collaborator

jupyter-server/jupyter_server#364 might be relevant?

@fcollonval
Copy link
Member

@3coins see official documentation to migrate lab extension and that one for the server part.

In popular extensions, you will be able to find PR to migrate to JLab3 like that one - that has a similar size as this one.

@fcollonval
Copy link
Member

Update typescript to 4.8.1

I advice updating to the same version of JupyterLab and not to the latest.

@3coins
Copy link
Collaborator Author

3coins commented Mar 14, 2022

@yuvipanda
Thanks for providing that info.

It seems like #501 is still in draft mode, and there hasn't been an update from the author since May 2021. I have 2 options here:

  1. Wait for #501 to be merged. In this case, this telemetry package won't need any server side components.
  2. Go ahead and update the telemetry package, remove the server extension when #501 is merged.

My inclination is towards going with #2, as my team is upgrading to JLab 3, and need this package to work with JLab 3. However, I will bring this up at this week's server meeting and go forward from there.

@yuvipanda
Copy link
Collaborator

@3coins (2) sounds good to me!

@Zsailer
Copy link
Member

Zsailer commented Mar 15, 2022

Yeah, I agree with (2) right now, also. @3coins, I'm happy to meet this week sometime to discuss futures plans for this repo, if you'd like. We can also discuss this at the jupyter-server meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants