-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install buttons in the extension manager are left aligned #14021
Comments
They also don't look at all like buttons; perhaps we should replace them with icons or some other visual design that looks like a button |
Yes I agree @JasonWeill , we could replace the "install" with a button. I suggest a design like this: I tried using an icon as well, but it looked overloaded as there is already an icon on the left. Also, it seems that there is no standard icon to represent the "install" icon. Those I saw looked very much like a "download" action, I think it's best to keep to the button illustrated above! As for the position, I suggest to put the button on the top-right, aligned (by the middle) with the title. This is a common position for actions in list items, plus it avoids creating a third line for the button. |
It seems that a few design considerations are missing in the above proposal:
|
Also, in visual hierarchy unique elements (extension name/description) should be more pronounced than the repetitive actions. The strong blue button seems to stand out too much. Also we were talking about bringing back the "from jupyter" indicator which was dropped for technical reason in 4.0 (for now) but is considered an important part of the UX (security tool really): See #12866 (comment) and #12866 (comment). Picture for update button and version: So everyone wants to put things in top right corner :) I hope this gives you a more complete picture. |
I agree with @krassowski's arguments for not putting the button / button bar on the same line with logo and other information about the extension. I'd say that in terms of positioning aligning the button / button bar to the right would be enough. @krassowski's arguments for not showing background color on buttons all the time to not visually overload the layout make sense. At the same time we color-code action buttons in other places in JupyterLab (for example, in dialogs) and it makes UI easier to navigate. Maybe showing background color on hover only would be a good middle ground (also if we would use color at all, all buttons should be consistent in terms of shape, either all rectangular or all round)?
@krassowski Below is a screen from version 3.2.9. "Install" button is positioned and looks to me the same as in head-of-master. Maybe 3.2.9 is not early enough? Could you please post a screenshot of style you have in mind? |
So in dialog windows colour background is fine because it's not a repetitive button and user has to press one. In places where the buttons are repetitive and completely optional we mostly use an icon and/or a very subtle background colour (except for the large blue button for add in file browser). Another way to delineate a button would be by adding a thin border or inset shadow but I don't think we do that elsewhere?
Right, I was wrong the styling was the same in 3.x - sorry. |
@krassowski @andrii-i thanks for the update! I've continued the research on this topic with the information you gave me. I have created a document illustrating the options you described. It is far from being complete, but it can be a good starting point to fuel discussions and iterations. These prototypes group solutions for this issue and #14098, and can help enhance #14078. The explanations by item are below, everything is illustrated in this Figma prototype. Each design has a large and condensed example. For state 2, there are 3 different options (A, B, C). All these options can be iterated on, as well as mixed together if we find it useful. I have intentionally prototyped the interactions with the info icon on a separate prototype. The statesTo my understanding, there are 2 different states to consider here:
The titleI think the title should not be in blue but in black (dark grey ideally). Blue is used for links and buttons, here it seems like an unnecessary use of color. The version (see this prototype for illustrations)
Disable and Uninstall buttons
Update button
Button styling
Further information to be displayed
How can I use a Figma prototype?In case you are not used to viewing Figma wireframes and prototypes, here are a few tips:
|
@GabrielaVives thank you for prototype, it's always easier to discuss and implement things with a reference. Because it touches on more than 1 issue and to facilitate discussion it might be worth to also create a separate issue for this Extension Manager prototype and list/link all issues it touches on |
Created #14205 that just aligns the Extension Manager buttonbar right as there is no consensus of other changes. |
Created #14213 to discuss the topics above in one issue. |
Description
Install buttons in the extension manager are left aligned rather than right, which seems to be more common in JLab.
Reproduce
Expected behavior
Install buttons in the extension manager are right-aligned.
Context
Operating System and version: MacOS 12.6.3
Browser and version: Chrome version 109.0.5414.87 (Official Build) (arm64)
JupyterLab version: head-of-master (WIP 4.0.0)
The text was updated successfully, but these errors were encountered: