Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow [extras] in install-minimums #119

Open
bollwyvl opened this issue Sep 10, 2022 · 2 comments
Open

Follow [extras] in install-minimums #119

bollwyvl opened this issue Sep 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@bollwyvl
Copy link

bollwyvl commented Sep 10, 2022

Problem

Some packages put rather important functionality behind [extras], and these are not followed up by install-minimums, which can leave a broken test state if not specified directly.

Proposed Solution

Alternatives

  • document options for install-minimums users
    • avoid using [extras] 😝
    • re-capture the upstream's [extra] as another extra

Additional context

  • example log for a PR that exists mostly to opt in to jsonschema[format-nongpl].
@bollwyvl bollwyvl added the enhancement New feature or request label Sep 10, 2022
@welcome
Copy link

welcome bot commented Sep 10, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@bollwyvl
Copy link
Author

In my particular case, the upstream had changed the name of the extra from [format_nongpl] to [format-nongpl], but I did find it worked after re-installing manually after the install-minimal action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant