Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min Version Check Should Handle Greater Than #176

Closed
blink1073 opened this issue Jan 11, 2023 · 2 comments · Fixed by #225
Closed

Min Version Check Should Handle Greater Than #176

blink1073 opened this issue Jan 11, 2023 · 2 comments · Fixed by #225
Labels
bug Something isn't working

Comments

@blink1073
Copy link
Contributor

Description

If a dependency includes the > directive, we currently convert it to == here. This is technically incorrect, as we should instead technically find the next available version greater than that version and constrain to that version.

Reproduce

Depend on a >, see example failure.

Expected behavior

We get the correct min version.

Context

We can use the PyPI JSON API to get the right version.

import requests
data = requests.get('https://pypi.org/pypi/notebook/json').json()
versions = list(data['releases'])
  • Operating System and version:
  • Browser and version:
  • JupyterLab version:
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@blink1073 blink1073 added the bug Something isn't working label Jan 11, 2023
@welcome
Copy link

welcome bot commented Jan 11, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@blink1073
Copy link
Contributor Author

cc @kevinbates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant