Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): update API endpoints for signifyd #5957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(connector): update API endpoints for signifyd #5957

wants to merge 1 commit into from

Conversation

kashif-m
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Described in #5956

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes 5xx thrown by payments API when FRM flows are consumed.

How did you test it?

Locally - using an increased stack size.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this Sep 19, 2024
@kashif-m kashif-m requested a review from a team as a code owner September 19, 2024 09:26
@kashif-m kashif-m linked an issue Sep 19, 2024 that may be closed by this pull request
[BUG] using FRM with Signifyd throws 5xx #5956
Open
2 tasks
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 19, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Filename Status
✔️ crates/router/src/connector/signifyd.rs Analyzed

@kashif-m kashif-m added C-bug Category: Bug A-FRM Area: Fraud & Risk Management labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@kashif-m kashif-m

Labels
A-FRM Area: Fraud & Risk Management C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] using FRM with Signifyd throws 5xx
2 participants
@kashif-m @srujanchikke