-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] Consolidate UserStatus
Enum into common_enums
File
#5967
Comments
@ThisIsMani i can help with this issue |
Hey @KekmaTime, |
@ThisIsMani I want to work on this |
Hey @KekmaTime, will you pick this up? If not I will assign this to @MridulY. |
Hey 👋 yes im working on this . I've been a bit busy so yes ill merge this today itself |
@KekmaTime, did you raise a PR for this? If yes, can you link this issue to that PR. |
Hi @ThisIsMani @gorakhnathy7, can I pick this issue as a part of my Hacktoberfest contributions? |
Hey @KekmaTime Are you still working on this? Kindly inform if you won't be able to pick this up, so we can assign it to someone else. @aniketh-varma meanwhile, you can checkout other issues in the repo. |
@KekmaTime, are you still working on this? I don't see any activity related to this issue. |
Hey @aniketh-varma Let me know, if you are interested in this? |
Hi @gorakhnathy7, sure, I can pick this |
Hey @aniketh-varma, Kindly let us know, if you're still working on the issue? If you have any questions or need assistance, feel free to reach out in the community. |
Hey @gorakhnathy7, yep, I am working on this issue. Apologies for the delay, I am new to Rust, so I was a bit sceptical about the coding practices. I will be raising the PR for this soon. Thanks! |
Hey @gorakhnathy7, I have raised the PR for this issue. Please have a look at the same whenever you get time. Thanks! |
Feature Description
We currently have duplicate
UserStatus
enum types defined in multiple locations:crates/api_models/src/user_role.rs
crates/diesel_models/src/enums.rs
To avoid redundancy and ensure consistency, these types should be centralized in the common enums file:
crates/common_enums/src/enums.rs
. This will make it easier to manage and maintain the UserStatus enum across the codebase.Possible Implementation
Task
UserStatus
enum from bothcrates/api_models/src/user_role.rs
andcrates/diesel_models/src/enums.rs
tocrates/common_enums/src/enums.rs
.UserStatus
in the codebase to point to the new location in the common enums file.Steps to Complete
crates/api_models/src/user_role.rs
file and locate theUserStatus
enum.crates/diesel_models/src/enums.rs
file and locate the otherUserStatus
enum.UserStatus
fromdiesel_models
file intocrates/common_enums/src/enums.rs
.UserStatus
in bothapi_models
anddiesel_models
to use the centralized definition fromcommon_enums
.Have you spent some time checking if this feature request has been raised before?
Submission Process:
Refer here for Terms and conditions for the contest.
The text was updated successfully, but these errors were encountered: