Fix/1031 #1035
Merged
Fix/1031 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-jeb
approved these changes
Sep 6, 2021
| let lastTsConfig: string | null | undefined; | ||
| return (tsConfig?: string) => { | ||
| // Check if the function was previously called with the same tsconfig | ||
| if (typeof lastTsConfig !== 'undefined' && (tsConfig ?? null) !== lastTsConfig) { |
There was a problem hiding this comment.
I think you can simplify it even more by initializing the lastTsConfig to null. Thus the only check you'll have to do is the equality check.
There was a problem hiding this comment.
I wasn't sure if you always call this function with a tsconfig parameter, since it is marked as optional in the calling function. So, to cover all cases, I did it this way. If the tsconfig parameter is always set, this simplification would still cover all cases, but the call signature should be changed.
There was a problem hiding this comment.
Fair point. Ok let's keep it this way.
This was referenced Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1031
What is the new behavior?
Ensures ts-node register is called once, and if tried to be called multiple times, asserts that all uses same tsconfig.
Does this PR introduce a breaking change?
Other information