fix(custom-webpack): warn about multiple tsconfigs for custom config #1041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1037
What is the new behavior?
Multiple
ts-node
registration attempts result in a warning, only first is really registered.Does this PR introduce a breaking change?
Other information
Initially issue was introduced with PR #1035. The original PR aimed to solve
ts-node
double registration with the same tsconfig and the base assumption was that it would never be called with two different tsconfigs.That assumption, however, turned to be wrong - in #1037 we see that the usage of
@nguniversal/builders
results inbrowser
andserver
builders run in the same process, which effectively throws an exception.This PR fixes this use case and presents a warning instead of exception.
@GerkinDev FYI.