Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-webpack): warn about multiple tsconfigs for custom config #1041

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

just-jeb
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1037

What is the new behavior?

Multiple ts-node registration attempts result in a warning, only first is really registered.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Initially issue was introduced with PR #1035. The original PR aimed to solve ts-node double registration with the same tsconfig and the base assumption was that it would never be called with two different tsconfigs.
That assumption, however, turned to be wrong - in #1037 we see that the usage of @nguniversal/builders results in browser and server builders run in the same process, which effectively throws an exception.
This PR fixes this use case and presents a warning instead of exception.

@GerkinDev FYI.

Copy link

@autoapproval autoapproval bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@just-jeb just-jeb changed the title fix(custom-webpack): warn about multitple tsconfigs for custom config fix(custom-webpack): warn about multiple tsconfigs for custom config Sep 29, 2021
@just-jeb just-jeb merged commit 74f3bc9 into master Sep 29, 2021
@just-jeb just-jeb deleted the warn-two-tsconfigs branch September 29, 2021 12:32
@GerkinDev
Copy link
Contributor

Thank you. Sorry for the thrown error: at least you know that there are cases where conflicting configuration may happen.

@just-jeb
Copy link
Owner Author

It's all good, I reviewed it, remember? 😄
I also presumed it's not a valid use case, but apparently it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v12.1.2 breaks SSR compilation with multiple tsconfigs.
2 participants