Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-webpack): support Webpack config written in TS #626

Merged
merged 3 commits into from
Nov 19, 2019
Merged

feat(custom-webpack): support Webpack config written in TS #626

merged 3 commits into from
Nov 19, 2019

Conversation

arturovt
Copy link
Collaborator

Closes #16

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

just-jeb
just-jeb approved these changes Nov 18, 2019
View reviewed changes
packages/custom-webpack/src/custom-webpack-builder.spec.ts Outdated
@@ -109,6 +109,33 @@ describe('CustomWebpackBuilder', () => {
}
});

it('should load the TS file specified in configuration', async () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test makes sure the TS file is loaded but it doesn't really check whether it is transpiled or not.
Maybe it's worth to make slightly different test for this use case and import a real ts file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree with you. I will try to find a workaround.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved webpack TS config to the e2e app.

@just-jeb just-jeb merged commit 479fa0b into just-jeb:master Nov 19, 2019
@arturovt arturovt deleted the feat/webpack-ts-config branch November 19, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-jeb just-jeb just-jeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Natively support webpack.config written in Typescript
2 participants
@arturovt @just-jeb