Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow merging loader name with loader object #912

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

just-jeb
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Loaders merge might fail because one of Angular loaders is defined as a string and not as an object. More info here and here.

What is the new behavior?

Builder update to a newer version of webpack-merge in which this issue is fixed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

@autoapproval autoapproval bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@just-jeb just-jeb merged commit a89a35d into master Dec 22, 2020
@just-jeb just-jeb deleted the fix-loaders-merge branch December 22, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant