fix(custom-webpack): change ts-node compilation target to include TS features
#941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tony . Not sure about this. I would have looked at the reproduction but I've seen there is a huge repo (the repo where your build is failing). |
just-jeb
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @just-jeb . I've removed
targetproperty that was introduced in this PR (c85cd10) since it's actually not needed. This property didn't exist in@10version and it worked perfect, but we've upgraded to@11version and started getting such errors.This property will require maintaining since it will require bumping target each time TS releases new features, which brings additional complexity.
And with a new change: