Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular 5 #230

Closed
axtho opened this issue Nov 2, 2017 · 7 comments
Closed

Support Angular 5 #230

axtho opened this issue Nov 2, 2017 · 7 comments

Comments

@axtho
Copy link

axtho commented Nov 2, 2017

With the release of Angular v5 it would be great if this generator could also work with ng5. Currently there seem to be a few issues with dependencies: e.g. minimist (probably from run-sequence?).

@axtho
Copy link
Author

axtho commented Nov 3, 2017

here is one step towards that: filipesilva/angular-quickstart-lib#61 (comment)

@flauc
Copy link

flauc commented Nov 4, 2017

It's a simple as doing this:

gulpfile.js

gulp.task('ngc', function () {
    ngc([ '--project', `${tmpFolder}/tsconfig.es5.json` ]);
    return Promise.resolve()
});

@axtho
Copy link
Author

axtho commented Nov 7, 2017

I confirm this works. Thanks!

@axtho axtho closed this as completed Nov 7, 2017
@abalad
Copy link

abalad commented Nov 7, 2017

@flauc thx it works

@jvandemo
Copy link
Owner

@flauc — Thank you for sharing, I'm working on an Angular 5 update and will include the fix 👍

@flauc
Copy link

flauc commented Nov 18, 2017

@jvandemo I'm happy to help, this is the best library generator out there 👍

@jvandemo
Copy link
Owner

v12.0.0 of the generator has been published with support for Angular 5 👍

Special thanks to @flauc for sharing the solution for ngc 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants