Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors cause gulp:watch and playground tasks to fail & exit #271

Open
txinfo opened this issue Jan 25, 2018 · 3 comments
Open

Comments

@txinfo
Copy link

txinfo commented Jan 25, 2018

If you run the gulp:watch or playground tasks and make a coding error that causes a compilation failure, it stops the watch task and requires a restart. The failure seems to happen in the rollup tasks as the index.js file doesn't exist after ngc failure:

[0] [11:36:43] Starting 'rollup:fesm'...
[0]
[0] events.js:160
[0] throw er; // Unhandled 'error' event

Since I would imagine this is quite a common occurrence, and it is annoying to have to keep restarting your watch/playground task mnually, it would be nice to handle compilation errors more gracefully.

@kkozlowski89
Copy link

Please do some changes in package.json file
You have to change playground script like that:

    "playground": "concurrently \"npm run build && npm run lite\" \"npm run playground:build\"",

I had similar issue. It resolved my problem.

@izifortune
Copy link
Collaborator

@txinfo can you please try to use this PR #274 ( or apply the changes ) in your project and see if the problem still persist?

@jvandemo
Copy link
Owner

@izifortune — Thank you for your follow-up, much appreciated! 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants