Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't list "closed" PRs #57

Open
rdohms opened this issue May 22, 2019 · 2 comments
Open

Don't list "closed" PRs #57

rdohms opened this issue May 22, 2019 · 2 comments
Labels
Enhancement New feature or request
Milestone

Comments

@rdohms
Copy link

rdohms commented May 22, 2019

Right now, if a PR is rejected (i.e closed without merging) it shows up in the changelog. Since this is a change that does not active affect the code base, it feels like it should not be included in the changelog by default.

Granted we could also remove it from the milestone, but I believe it can also remain there for organization reasons, like knowing which release the PR had been intended for and finding more history on it.

@jwage
Copy link
Owner

jwage commented May 22, 2019

Currently when this happens I do what you suggested and remove it from the milestone. Not opposed to adding this though if the github API supports differentiating the data.

@rdohms
Copy link
Author

rdohms commented May 22, 2019

yes, so a merged PR has: state: closed and merged: true, a closed PR has merged: false.

@jwage jwage added this to the 1.3.0 milestone May 22, 2019
@jwage jwage added the Enhancement New feature or request label May 22, 2019
@WyriHaximus WyriHaximus modified the milestones: 1.3.0, 1.4.0 Jan 20, 2021
@WyriHaximus WyriHaximus modified the milestones: 1.4.0, 1.5.0 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants