markerIcon from sys_category not shown on fe map anymore

[peerlight]

after upgrade of maps2 from 9.3.11 to 10.0.7 via composer on TYPO3 11.5.12 markerIcons defined in sys_category.maps2_marker_icons are not shown anymore.

it doesn't matter if

• plugin has [settings.categories]
• there are one or more categories active
• Google Maps or OpenStreetMaps

markerIcon defined in tx_maps2_domain_model_poicollection.marker_icons work

[rasgor]

The function

public function getMarkerIcon(): string

within EXT:maps2/Classes/Domain/Model/PoiCollection.php

has following code at line 338:

if ($this->markerIcons->count() === 0) { return ''; }

This removes the possibility of MarkerIcon inhiterance from a category which is retrieved at line 335.

[rasgor]

I would create a pull request, but maybe the inhiterance behaviour of the marker icon is under rework by @froemken

[sfroemkenjw]

Argh, yes. Returning an empty string at that position was a bad idea:
https://github.com/jweiland-net/maps2/blob/10.0.10/Classes/Domain/Model/PoiCollection.php#L347

I'm just working on version 12 where I already solved that problem:
https://github.com/jweiland-net/maps2/blob/typo3_12_compatibility/Classes/Domain/Model/PoiCollection.php#L343

I keep that issue open as I think, that I will backport that to version 10.*

Stefan