Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Create tag for version 0.3.1 #55

Open
YetAnotherMinion opened this issue Aug 28, 2016 · 2 comments
Open

Create tag for version 0.3.1 #55

YetAnotherMinion opened this issue Aug 28, 2016 · 2 comments

Comments

@YetAnotherMinion
Copy link
Contributor

YetAnotherMinion commented Aug 28, 2016

@jwilm Would it be possible to create a tag pointing to the master (4b8d3c7) for version 0.3.1. I am looking to submit a PR to update Valloric's ycmd, which includes this project as a submodule. Currently he is using a commit of racerd from 3 months ago. Having a tag would be cleaner way to suggest a change to Valloric than just suggesting updating to a random commit.

Please let me know if there is any further testing that needs to be done before creating a tag. I am happy to volunteer my time to get this code into a state for release.

I will build ycmd with this current master and use it with YCM as an integration test.

@micbou
Copy link
Contributor

micbou commented Aug 31, 2016

I am a collaborator of the ycmd project. We recently updated the racerd submodule to include PR #53 but not yours because it was merged a few days later. If you feel that the changes introduced by your PR are important enough to be included in ycmd then send us a PR like ycm-core/ycmd#580.

Having a tag would be cleaner way to suggest a change to Valloric than just suggesting updating to a random commit.

Git submodules are necessary pointing to a commit. We can't specify a tag. Yes, we could make it point to a commit that corresponds to a tag but there would not be much benefit, especially for a dependency like racerd that is still in development according to its semantic version. So, don't worry about tags for ycmd submodules.

@rillian
Copy link
Contributor

rillian commented Jan 11, 2017

0.3.2 and 0.3.3 could use tags too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants