Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Don't change video thumbnail to black background during load #79

Open
dominictobias opened this issue Aug 21, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@dominictobias
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It would be preferable for us if during a video load, the thumbnail isn't removed.

This illustrates the problem. Note the flash of black on every video as it is played:

Screen.Recording.2024-08-21.at.5.08.56.PM.mov
@dominictobias dominictobias added the needs-grooming Has not been reviewed by codeowners for scope/validation label Aug 21, 2024
@Jmilham21 Jmilham21 added enhancement New feature or request and removed needs-grooming Has not been reviewed by codeowners for scope/validation labels Sep 4, 2024
@trevorpreston
Copy link

trevorpreston commented Oct 16, 2024

This is a big one for me. I am using this library for an enterprise-level application, which, much like @dominictobias' demo, is a continuous feed videos with a few images here and there. This problem where the screen flashes to black is happening any time a user scrolls between frames, and is unfortunately holding up our release. If anyone has successfully built a scrolling feed of videos like the one above and not experienced this issue, I'd greatly appreciate your insight.

Forgive my ignorance, but does the "enhancement" tag imply that this is the current intended behavior? My instinct says this feels like a bug, but every open source project interprets things differently. Does the tag say anything about the priority of this ticket?
cc: @Jmilham21

I am digging through the module and looking for a fix. If I find a solution I'll certainly PR it, but I am being limited to the end of this week before being tasked with searching for a different player. Any assistance is greatly appreciated!

@dominictobias
Copy link
Contributor Author

dominictobias commented Oct 17, 2024

I know this isn't ideal but we actually removed the thumbs:

// Because JW initially shows the thumb, then goes black while loading the video,
  // it actually looks worse than just starting with black as it causes a flicker.
  // Raised https://github.com/jwplayer/jwplayer-react-native/issues/79
  const playlistWithoutThumb = useMemo(
    () =>
      playlist.map(item => ({
        ...item,
        image: undefined,
      })),
    [playlist],
  )

Another thing you could try is to overlay the thumb on top of the video and then hide it yourself on a load event.

Neither solution is of course ideal 🤷‍♂️

@Jmilham21
Copy link
Collaborator

This use case is possible with some customization of the UI but I agree the UI/UX isn't ideal out of the box. I'd ask you to create a JWP Support ticket for this, so we can better internally review and come up with a solution for you here.

I have created something similar for Android in the past, where the video thumbnail is loaded into a separate view and hidden/shown when the content is not playing. It's certainly possible to do here, but it would require some custom logic or a modification to the native SDK to allow thumbnails to be displayed whenever content is loading.

The use case is valuable and something we should look into, so please create the internal ticket so I can get it up for internal review. If you wanted to try it yourself, I'd suggest taking the path I explained above, with a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants