Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying expiration without leeway throws exception #206

Closed
fightingtheboss opened this issue May 29, 2017 · 0 comments
Closed

Verifying expiration without leeway throws exception #206

fightingtheboss opened this issue May 29, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@fightingtheboss
Copy link

Both in 1.5.6 and in master, trying to verify the exp of a token without providing an explicit leeway throws the following exception:

TypeError: nil can't be coerced into Integer

This is because this line (on master) relies on the return value from the options Hash to add time to the exp integer. If leeway isn't set in the options, the above error is thrown.

I think the leeway should default to 0 if not found, as seems to be the assumption in the specs.

@excpt excpt added the bug label Jun 24, 2017
@excpt excpt added this to the Version 2.0.0 milestone Aug 24, 2017
@excpt excpt self-assigned this Aug 24, 2017
@excpt excpt closed this as completed in a993b40 Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants