Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The README says it uses an algorithm by default #226

Closed
alebian opened this issue Sep 4, 2017 · 2 comments
Closed

The README says it uses an algorithm by default #226

alebian opened this issue Sep 4, 2017 · 2 comments
Assignees
@excpt
Labels
bug documentation
Milestone
Version 2.1.0

Comments

@alebian
Copy link

alebian commented Sep 4, 2017 •
edited
Loading

Hi, the README says it uses HS256 by default but since #184 you must provide an algorithm option

We should remove the word "default" from readme
@excpt
Copy link
Member

excpt commented Sep 6, 2017 •
edited
Loading

This is also mentioned in #227 and explains this in more detail. Process will continue there.

@excpt excpt closed this as completed Sep 6, 2017
@excpt
Copy link
Member

excpt commented Sep 6, 2017

You are correct, I mixed things up. #227 played tricks on my mind. Reopen.

@excpt excpt reopened this Sep 6, 2017
@excpt excpt self-assigned this Sep 6, 2017
@excpt excpt added this to the Version 2.1.0 milestone Sep 6, 2017
@excpt excpt mentioned this issue Sep 6, 2017
Closed
@excpt excpt added the bug label Sep 6, 2017
@excpt excpt mentioned this issue Oct 5, 2017
Merged
@excpt excpt closed this as completed in #242 Oct 5, 2017
@excpt excpt mentioned this issue Mar 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@excpt excpt

Labels
bug documentation
Projects
None yet
Milestone
Version 2.1.0
Development

No branches or pull requests
2 participants
@excpt @alebian