Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the fragment shaders iusse #4

Open
lookfuyao opened this issue Jun 9, 2017 · 4 comments
Open

the fragment shaders iusse #4

lookfuyao opened this issue Jun 9, 2017 · 4 comments

Comments

@lookfuyao
Copy link

The param in fragment shaders " uniform vec2 uFov "
uFov is never used, and the value from "fov x y" cannot work!
Can you help to fix it?

@jywarren
Copy link
Owner

jywarren commented Jun 9, 2017

I actually struggled with the shaders a lot -- i dont know webgl very well. Do you know anyone who can help?

@lookfuyao
Copy link
Author

Sorry, I can't help now, I'll paste it if I found a way!

@lookfuyao
Copy link
Author

Hi,
I just add

	vMapping.x = vMapping.x + uFov.x;
	vMapping.y = vMapping.y + uFov.y;

before
vec4 texture = texture2D(uSampler, vMapping);
at fragment.glsl
And it can work at my android project. Maybe you can modify you js code and have a check.

@jywarren
Copy link
Owner

Ah, very cool! We have resolved the issue, I think, is that right? #5

But maybe I'm mistaken.

What line of code would yours change, can you show us the exact line of code? Or even would you open a pull request? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants